Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[doc] A small change to README #3322

Merged
merged 1 commit into from
Apr 12, 2022
Merged

[doc] A small change to README #3322

merged 1 commit into from
Apr 12, 2022

Conversation

jolestar
Copy link
Member

@jolestar jolestar commented Apr 8, 2022

update --local-account-dir args to ~/.starcoin/main/account_vaults

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@jolestar
[doc] A small change to README
f69a58a 
update --local-account-dir args to ~/.starcoin/main/account_vaults
@jolestar jolestar requested a review from sanlee42 April 8, 2022 02:07
@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #3322 (f69a58a) into master (0986ffc) will decrease coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3322      +/-   ##
==========================================
- Coverage   32.19%   31.95%   -0.23%     
==========================================
  Files         500      500              
  Lines       46727    46787      +60     
  Branches    21252    21307      +55     
==========================================
- Hits        15040    14948      -92     
+ Misses      17804    17755      -49     
- Partials    13883    14084     +201
Flag Coverage Δ
unittests 31.95% <ø> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
commons/accumulator/src/tree.rs 51.71% <0.00%> (-11.21%) ⬇️
executor/src/block_executor.rs 25.54% <0.00%> (-8.51%) ⬇️
vm/natives/src/vector.rs 16.67% <0.00%> (-8.33%) ⬇️
network-p2p/src/transport.rs 15.10% <0.00%> (-7.54%) ⬇️
state/state-store-api/src/lib.rs 43.75% <0.00%> (-6.25%) ⬇️
commons/forkable-jellyfish-merkle/src/lib.rs 40.62% <0.00%> (-6.13%) ⬇️
config/src/helper.rs 47.06% <0.00%> (-5.88%) ⬇️
vm/natives/src/token.rs 24.45% <0.00%> (-4.44%) ⬇️
network-rpc/api/src/lib.rs 18.10% <0.00%> (-2.85%) ⬇️
chain/src/chain.rs 34.68% <0.00%> (-2.72%) ⬇️
... and 75 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0986ffc...f69a58a. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Apr 8, 2022

Benchmark for a4d6222

Click to view benchmark
Test Base PR %
accumulator_append 590.1±10.63µs 586.7±10.74µs -0.58%
block_apply/block_apply_10 267.4±1.42ms 265.8±0.55ms -0.60%
block_apply/block_apply_1000 27.2±0.02s 27.5±0.02s +1.10%
get_with_proof/db_store 36.1±0.27µs 36.7±0.44µs +1.66%
get_with_proof/mem_store 31.3±0.33µs 31.3±0.23µs 0.00%
put_and_commit/db_store/1 94.7±4.82µs 94.7±4.68µs 0.00%
put_and_commit/db_store/10 858.4±40.28µs 860.9±37.89µs +0.29%
put_and_commit/db_store/100 7.3±0.30ms 7.4±0.32ms +1.37%
put_and_commit/db_store/5 436.5±23.08µs 436.1±22.08µs -0.09%
put_and_commit/db_store/50 3.8±0.19ms 3.9±0.17ms +2.63%
put_and_commit/mem_store/1 60.9±5.37µs 62.0±5.51µs +1.81%
put_and_commit/mem_store/10 570.8±47.40µs 578.4±45.43µs +1.33%
put_and_commit/mem_store/100 5.6±0.80ms 5.7±0.81ms +1.79%
put_and_commit/mem_store/5 287.2±24.28µs 292.2±23.91µs +1.74%
put_and_commit/mem_store/50 2.8±0.18ms 2.9±0.19ms +3.57%
query_block/query_block_in(10)_times(100) 3.8±0.14ms 3.9±0.09ms +2.63%
query_block/query_block_in(10)_times(1000) 39.0±0.81ms 38.8±1.17ms -0.51%
query_block/query_block_in(10)_times(10000) 385.9±8.44ms 386.7±5.17ms +0.21%
query_block/query_block_in(1000)_times(100) 977.1±7.77µs 952.0±6.33µs -2.57%
query_block/query_block_in(1000)_times(1000) 9.8±0.07ms 9.5±0.06ms -3.06%
query_block/query_block_in(1000)_times(10000) 98.0±0.72ms 95.3±0.93ms -2.76%
storage_transaction 1053.0±279.12µs 1052.2±279.77µs -0.08%
vm/transaction_execution/1 315.9±0.74ms 317.2±3.92ms +0.41%
vm/transaction_execution/10 99.4±1.78ms 98.7±0.45ms -0.70%
vm/transaction_execution/20 91.1±0.40ms 90.9±0.90ms -0.22%
vm/transaction_execution/5 121.3±0.42ms 120.7±0.42ms -0.49%
vm/transaction_execution/50 102.6±0.16ms 102.7±0.86ms +0.10%

@jolestar jolestar merged commit 78db4c7 into master Apr 12, 2022
@jolestar jolestar deleted the jolestar-readme branch April 12, 2022 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LemonHX LemonHX LemonHX approved these changes

@sanlee42 sanlee42 Awaiting requested review from sanlee42

@nanne007 nanne007 Awaiting requested review from nanne007

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jolestar @LemonHX